-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Update node to 20.19.2 #16644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4,183
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Jun 18, 2025
93a9e0d
to
52f6cd4
Compare
mydea
added a commit
that referenced
this pull request
Jun 18, 2025
) Extracted this out of #16644, for clarity
AbhiPrasad
approved these changes
Jun 18, 2025
I think I will wait for nodejs/node#57869 (comment) to land then we can run RR in Node 20 again! |
ok, seems the node release will take a bit more time, will bump this anyhow, we can adjust tests later! Instead, I'll just run the "current" test on node 22 for now, where this is already fixed. |
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump pnpm to the latest v9 version (used for E2E tests) and remove the hard-pinned 24.x version for matrix tests, which should be fine by now I guess?
note: react router in SPA mode is not working in this node version, unrelated to Sentry: remix-run/react-router#13828